Repository navigation
feat: Register the Makeswift preview session - #1408
Merged
Conversation
parthshahp
commented
Oct 8, 2026
Contributor
Author
There was a problem hiding this comment.
For now (and the next few PRs) we will be placing Makeswift specific code in stencil-start.js. A refactor exists at the end of the stack to create our own Makeswift preview class.
parthshahp
added this pull request to stack #1414
October 8, 2026 15:12
parthshahp
removed this pull request from stack #1414
October 8, 2026 15:17
parthshahp
added this pull request to stack #1417
October 8, 2026 15:17
parthshahp
marked this pull request as ready for review
October 8, 2026 17:56
jairo-bc
approved these changes
Oct 19, 2026
parthshahp
force-pushed
the
parthshah/ltrac-1793-stencil-cli-register-the-preview-session-and-hold-the-access
branch
from
October 19, 2026 19:06
6898b4e to
d62cb07
Compare
Contributor
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Register a Makeswift preview session when the tunnel starts, and hold the returned access token for later requests.
Tickets / Documentation
cc @bigcommerce/storefront-team