feature/AB#24282 - Remain on Tab After Refresh - #3053
Draft
plavoie-BC wants to merge 3 commits into
Draft
plavoie-BC wants to merge 3 commits into
plavoie-BC wants to merge 3 commits into
Conversation
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Restoration currently overrides an application’s default right tab and also persists across ordinary navigation rather than refreshes only.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds tab persistence across refreshes for application and applicant detail pages.
Changes:
- Introduces local-storage-backed tab restoration and fallback handling.
- Integrates the utility into both detail pages and the global script bundle.
- Refreshes AutoUI selector metadata and CLI path handling.
| File | Description |
|---|---|
Pages/GrantApplications/Details.js |
Enables application tab persistence. |
Pages/Applicants/Details.js |
Enables applicant tab persistence. |
wwwroot/js/TabUtils.js |
Implements tab storage, restoration, fallback, and cleanup. |
UnityThemeUX2GlobalScriptContributor.cs |
Adds TabUtils to the global bundle. |
scripts/selector-contract.mjs |
Improves direct-execution detection. |
cypress/selectors/registry.json |
Regenerates selector registry metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const TAB_TOGGLE_SELECTOR = '[data-bs-toggle="tab"]'; | ||
| let logoutStarted = false; | ||
|
|
||
| function initialize(options) { |
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tab persistence across refreshes for application and applicant detail pages.
Changes:
Pages/GrantApplications/Details.jsPages/Applicants/Details.jswwwroot/js/TabUtils.jsUnityThemeUX2GlobalScriptContributor.csscripts/selector-contract.mjscypress/selectors/registry.json