Repository navigation
Conversation
p0deje
changed the title
WORKSPACE modeWORKSPACE mode
sushain97
approved these changes
Oct 12, 2026
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: 3.4.11 | ||
| ruby-version: 3.3.12 |
Collaborator
There was a problem hiding this comment.
Intentionally moving backwards?
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: 3.4.11 | ||
| ruby-version: 3.3.12 |
| ) | ||
|
|
||
| direct_dep_names = {name: None for name in direct_dep_names}.keys() | ||
| direct_dev_dep_names = {name: None for name in direct_dev_dep_names if name not in direct_dep_names}.keys() |
Collaborator
There was a problem hiding this comment.
Are we not using set to maintain compat with old versions of Bazel?
| ("LIBYAML_PREFIX", "libyaml", "libyaml", "PSYCH"), | ||
| ("OPENSSL_PREFIX", "openssl@3", "openssl", "OPENSSL"), | ||
| ]: | ||
| prefix = _execute_command(repository_ctx, ["dist/bin/ruby", "-rrbconfig", "-e", "puts ENV['%s']" % variable]) |
Collaborator
There was a problem hiding this comment.
Hm, ideally we would parallelize this…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large chunk of work for the upcoming 1.0 release, which includes many breaking changes:
WORKSPACEmode support is completely removed, and now the ruleset can only be used via Bzlmod.WORKSPACEmode.rb_bundlerepository rule, userb_bundle_fetchinstead.