Repository navigation
Conversation
Owner
|
Presumably you're using XI because it's not seekable? Or why does this use XI? |
Contributor
Author
|
Yes, XI was chosen because libsndfile reports it as non-seekable, as in the existing non-seekable-file tests. It makes the short read reproducible with a regular temporary file. The bug also occurs with RAW audio from a POSIX pipe: requesting more frames than remain raises the same assertion. The added stereo pipe test covers that case too. All five new cases pass locally, including reads at EOF and buffers retained after closing the file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffer_read()assumes every requested frame was read. That fails at EOF on non-seekable files: a valid five-frame XI file raisesAssertionErrorforbuffer_read(99, dtype="int16"), whileread(99, dtype="int16")returns its five samples.Size the returned CFFI buffer using the actual native frame count. The buffer retains ownership of its allocation. This also handles a zero-frame read at EOF.
Five regressions cover all four supported dtypes, retained buffers after close/GC, and a stereo RAW pipe. They fail against unchanged master. On two recorded speech clips, all 24 XI/RAW-pipe loading flows now finish with exactly the reference samples and frame-energy/spectral features. Ten existing array/seekable-buffer controls remain exact.
Full suite: 376 passed on CPython and PyPy with libsndfile 1.2.2. The two existing pyright errors at
dirname(_libname)reproduce on unchanged master; no new diagnostics. Linux validation only; this does not changeblocks()or virtual-I/O callback handling.