Repository navigation
Conversation
[Medium impact] This PR appears safe to merge. SummaryThe PR makes all four file reads and writes in
Reviews (1) · Last reviewed commit: "Read and write files as UTF-8" · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, in Python's default mode, running markdown-code-runner on a
markdown file crashes and leaves the file empty.
The file is opened for writing with the locale's encoding, which is cp1252
on most Western Windows setups. Opening it for writing empties it, and then writing the
⚠️ This content is auto-generatedmarker fails, since cp1252 has no⚠️.The output file is the input file by default, so the original is gone.
To check, in Git Bash on Windows with Python 3.9 to 3.14 and without
PYTHONUTF8set:Before:
UnicodeEncodeError, anddemo.mdis 0 bytes. After: the output iswritten and the file keeps its text.
This passes
encoding="utf-8"to the four reads and writes inmarkdown_code_runner.py. CI runs on Ubuntu, where UTF-8 is the default,which is why it did not show there.
No test added: on Ubuntu a test would pass with or without the fix.
Found with qikly, an AI-assisted test tool
I maintain, when the project's own tests failed on Windows. I reproduced it
by hand, and reviewed and tested this change myself.