Repository navigation
feat(payments): type the checkout's shipping address and fee - #350
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.56-pr.350.bba16c2Prefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.56-pr.350.bba16c2"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.56-pr.350.bba16c2"
}
}
Preview published to npm registry — try new features instantly! |
guyofeck
self-requested a review
October 22, 2026 10:44
guyofeck
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Types and docs for shipping on checkouts:
CreateCheckoutParams.shipping: an optional{ address?, amount? }.amountis the shipping fee in minor units, computed by the app's backend.addressis one the app collected, needed when the fee depends on it. The provider shows it locked, so the buyer can't change it.Purchase: gainsshipping_address, returned to service role callers only, likemetadata, andshipping_amount.CheckoutShippingAddress.shippingwithinvalid_request.Notes
createCheckoutalready sends its params as-is.shipping, since it rejects the field as unknown until then.Testing
Type-only change;
tscand the existing unit tests pass in CI.🤖 Generated with Claude Code