Repository navigation
error-fn-test: make processing order clearer - #236
Merged
Merged
Conversation
Docs refer to `error-fn-test` as an example of collecting all errors. This test happened to pass because `:spec` map size is small. For larger maps processing order, and therefore errors order, would be indeterminate. Add comment and explicitly sort collected errors to make it clear that order is indeterminate. Reformat expected map to make it easier to eyeball :msg values. Closes #235
Contributor
|
Thank you, sir! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs refer to
error-fn-testas an example of collecting all errors.This test happened to pass because
:specmap size is small. For larger maps processing order, and therefore errors order, would be indeterminate.Add comment and explicitly sort collected errors to make it clear that order is indeterminate.
Reformat expected map to make it easier to eyeball :msg values.
Closes #235