Repository navigation
chore(ci): make stable release the default option on v1 release workflow - #2711
nborges-aws wants to merge 1 commit into
Conversation
Package TarballHow to installgh release download pr-2711-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-1.0.0.tgz |
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
The change is a one-line default flip plus an option reorder on the channel input of release-prepare.yml. It's consistent with the rest of the pipeline:
default: stableis a valid member ofoptions, and reordering to[stable, rc]keeps the implicit first-option default aligned with the explicit one, so behavior is unambiguous either way.- The version logic still handles both directions correctly now that
package.jsonis at1.0.0: a stable dispatch takes thebun pm version "$BUMP"path, and an open rc series still graduates via${CURRENT%%-*}. sync-vended-cdk.tsis invoked withlatestfor anything other thanrc, andrelease-main-and-preview.ymlderives the dist-tag from the version string (*-rc.*), so neither side needs a matching change.
No blocking issues. One optional, pre-existing observation (not introduced here): the bump input has no explicit default, so GitHub defaults it to the first option, major. With the channel now defaulting to stable, a "click dispatch without reading" run prepares a major stable release rather than an rc. If you want to reduce that blast radius, adding default: patch (and reordering options to [patch, minor, major]) would make the zero-thought dispatch the safest one. Feel free to skip if the release process always sets both inputs deliberately.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2711 +/- ##
============================================
- Coverage 96.62% 96.54% -0.08%
============================================
Files 706 706
Lines 58447 58561 +114
============================================
+ Hits 56472 56539 +67
- Misses 1975 2022 +47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
v1 / refactor is now released as GA, instead of RC. This PR updates the release workflow to set the default release channel to 'stable' instead of 'RC'.
Type of Change
Testing
How have you tested the change?
bun testbun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.