Skip to content

chore(ci): make stable release the default option on v1 release workflow - #2711

Open
nborges-aws wants to merge 1 commit into
refactorfrom
v1-release-workflow
Open

nborges-aws wants to merge 1 commit into
refactorfrom
v1-release-workflow

Conversation

@nborges-aws

Copy link
Copy Markdown
Contributor

Description

v1 / refactor is now released as GA, instead of RC. This PR updates the release workflow to set the default release channel to 'stable' instead of 'RC'.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran bun test
  • I ran the relevant end-to-end tests with bun run test:e2e, or explained why they are not applicable
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • If I modified src/assets/, I updated affected snapshots with bun test <test-file> --update-snapshots and committed them

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@nborges-aws
nborges-aws requested a review from a team October 26, 2026 21:54
@github-actions github-actions Bot added the size/xs PR size: XS label Oct 26, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-1.0.0.tgz

How to install

gh release download pr-2711-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-1.0.0.tgz

@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 26, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

The change is a one-line default flip plus an option reorder on the channel input of release-prepare.yml. It's consistent with the rest of the pipeline:

  • default: stable is a valid member of options, and reordering to [stable, rc] keeps the implicit first-option default aligned with the explicit one, so behavior is unambiguous either way.
  • The version logic still handles both directions correctly now that package.json is at 1.0.0: a stable dispatch takes the bun pm version "$BUMP" path, and an open rc series still graduates via ${CURRENT%%-*}.
  • sync-vended-cdk.ts is invoked with latest for anything other than rc, and release-main-and-preview.yml derives the dist-tag from the version string (*-rc.*), so neither side needs a matching change.

No blocking issues. One optional, pre-existing observation (not introduced here): the bump input has no explicit default, so GitHub defaults it to the first option, major. With the channel now defaulting to stable, a "click dispatch without reading" run prepares a major stable release rather than an rc. If you want to reduce that blast radius, adding default: patch (and reordering options to [patch, minor, major]) would make the zero-thought dispatch the safest one. Feel free to skip if the release process always sets both inputs deliberately.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 26, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.54%. Comparing base (9ab9ed9) to head (c2c4bac).
⚠️ Report is 7 commits behind head on refactor.

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #2711      +/-   ##
============================================
- Coverage     96.62%   96.54%   -0.08%     
============================================
  Files           706      706              
  Lines         58447    58561     +114     
============================================
+ Hits          56472    56539      +67     
- Misses         1975     2022      +47     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants