Repository navigation
fix(cli): resolve Windows commands from explicit PATH entries - #2705
Merged
Merged
Conversation
Resolve bare commands through absolute PATH entries before launching them on Windows. Route process creation through the shared subprocess helpers and pass the Windows lookup setting to child processes.
agentcore-devx-automation
Bot
added
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-2705-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.31.1.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
agentcore-devx-automation
Bot
removed
claude-security-reviewing
Contributor
Coverage Report
|
Contributor
Author
|
CI status note:
All source-validation checks passed, including the build, all three unit-test shards, all four integration-test shards, coverage, lint, type checking, formatting, CodeQL, and the external end-to-end build. |
Keep caller-requested shell execution disabled and add focused Windows coverage for commands and arguments containing metacharacters.
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
jariy17
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve bare commands against absolute PATH entries on Windows before launch, while preserving PATHEXT and command-shim support. Route CLI process creation through shared subprocess helpers and propagate the Windows lookup setting to child processes. Explicit paths retain their existing behavior.
Related Issue
Not applicable.
Documentation PR
Not applicable; no user-facing documentation changes are needed.
Type of Change
Testing
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.