Repository navigation
fix(io): resolve Windows commands from explicit PATH entries - #2704
Merged
Merged
Conversation
Resolve bare Windows commands using absolute PATH entries before launching them. Route browser launch and process cleanup through the shared launcher, and propagate the Windows lookup setting to child processes.
Contributor
Package TarballHow to installgh release download pr-2704-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-1.0.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Author
|
CI status note:
The relevant platform validation is green: Windows, macOS, CodeQL, and the external end-to-end build all passed. |
jariy17
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve bare Windows commands against absolute PATH entries before launching them, while preserving PATHEXT and command-shim support. Explicit relative and absolute paths keep their existing behavior.
Route browser launch and Windows process cleanup through the shared process launcher. Apply the Windows lookup setting at CLI startup so child processes use consistent command lookup.
Related Issue
Not applicable.
Documentation PR
Not applicable; this changes internal process-launch behavior without changing the command interface.
Type of Change
Testing
bun test— 4,709 passed, 6 Windows-only tests skipped on Linux, 0 failedbun run typecheckbun run lint:checkbun run format:checkbun run buildbun run secrets:checksrc/assets/was not modifiedChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.