Skip to content

fix(io): resolve Windows commands from explicit PATH entries - #2704

Merged
notgitika merged 1 commit into
refactorfrom
fix/windows-executable-resolution-v1
Oct 26, 2026
Merged

notgitika merged 1 commit into
refactorfrom
fix/windows-executable-resolution-v1

Conversation

@notgitika

Copy link
Copy Markdown
Contributor

Description

Resolve bare Windows commands against absolute PATH entries before launching them, while preserving PATHEXT and command-shim support. Explicit relative and absolute paths keep their existing behavior.

Route browser launch and Windows process cleanup through the shared process launcher. Apply the Windows lookup setting at CLI startup so child processes use consistent command lookup.

Related Issue

Not applicable.

Documentation PR

Not applicable; this changes internal process-launch behavior without changing the command interface.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

  • I ran bun test — 4,709 passed, 6 Windows-only tests skipped on Linux, 0 failed
  • Relevant end-to-end tests are not applicable because this change does not modify deployment or AWS interactions
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • I ran bun run secrets:check
  • src/assets/ was not modified

Checklist

  • I have read the CONTRIBUTING document
  • I added focused command-resolution tests and a Windows process-launch regression test
  • No documentation changes are needed for this internal behavior change
  • No new example is needed because the command interface is unchanged
  • My changes generate no new warnings
  • No dependent changes are required

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

Resolve bare Windows commands using absolute PATH entries before launching them. Route browser launch and process cleanup through the shared launcher, and propagate the Windows lookup setting to child processes.
@notgitika
notgitika requested a review from a team October 26, 2026 15:54
@github-actions github-actions Bot added the size/m PR size: M label Oct 26, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-1.0.0.tgz

How to install

gh release download pr-2704-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-1.0.0.tgz

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 26, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 26, 2026
@notgitika

Copy link
Copy Markdown
Contributor Author

CI status note:

  • verify / Linux reaches the dependency-audit step and fails on the repository’s current dependency state. This branch does not modify dependency manifests, lockfiles, or audit configuration; the build and test portions of the job completed successfully.
  • harness-review / review stopped because the automated reviewer reached its maximum generation limit before producing a result. It did not report a code finding.

The relevant platform validation is green: Windows, macOS, CodeQL, and the external end-to-end build all passed.

@notgitika
notgitika merged commit 49eec84 into refactor Oct 26, 2026
25 of 28 checks passed
@notgitika
notgitika deleted the fix/windows-executable-resolution-v1 branch October 26, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants