Repository navigation
feat(runtime): accept externally managed container-build roles - #2700
Open
proton0210 wants to merge 2 commits into
Open
proton0210 wants to merge 2 commits into
proton0210 wants to merge 2 commits into
Conversation
proton0210
force-pushed
the
feature/runtime-container-roles-2698
branch
from
October 25, 2026 09:50
90532c3 to
237c5ff
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
--container-build-role-arnand--container-build-handler-role-arntoadd runtimeon the v1/refactor branch. Validates partition-aware IAM role ARNs and persists them inagentcore.json. Supplying either flag to the current--languageworkflow selects a Container build; the runtime docs explain the required Dockerfile and role permissions. CodeZip imports reject build roles. Existing projects retain their behavior.Build and deploy reject installed CDK schemas that would silently discard these fields, before provisioning credentials or synthesizing.
Includes a CDK maintainer handoff in
docs/patches/, verified against the published@aws/agentcore-cdk@1.0.0package. The patch imports supplied roles immutably, preserves defaults and shared-project identities, rejects conflicting shared-role configurations, and wires runtime settings through the build infrastructure. Documentation covers trust relationships, required permissions, bootstrap scope, and applying/verifying the patch.Dependency: the private CDK repository must port the package patch to its TypeScript source, regenerate declarations/source maps, and publish a release. This PR does not claim that dependency is already released; the CLI compatibility check prevents silently creating roles with the current package.
Related Issue
Refs #2698 — public CLI implementation and CDK handoff. The issue should remain open until the CDK dependency is released.
Documentation PR
Included here:
docs/container-build-roles.md, generatedcommand.md, package patch, and standalone verification script.Type of Change
Testing
bun test: 4,720 passed, 5 skipped, 0 failed; 6 snapshots.bun run typecheckbun run lint:checkusing Node 22bun run format:checkbun run secrets:checkbun run buildbun run audit: 9 pre-existing dependency advisories (1 high, 4 moderate, 4 low). Reproduced with the unchanged upstreamrefactorpackage manifest and lockfile; this PR changes neither.add runtime --language python, selects Container, and rejects the unsupported published CDK before synthesis.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.