Repository navigation
Conversation
soujasK
force-pushed
the
fix/fifo-short-circuit-model-error
branch
from
October 26, 2026 10:41
92dc822 to
1545ba0
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8661
Summary
Changes
Once a record fails,
SqsFifoPartialProcessorshort-circuits the remaining records (or the rest of the failed group withskip_group_on_error=True) and converts them with the customer's model before passing them tofailure_handler. That conversion was outside anytry, so a record that didn't match the model raised out ofprocess()and failed the whole invocation.Short-circuited records never reach the record handler, so if the model conversion fails they're now registered as event source data classes, like other poison pills. Records that do match the model are still registered as model instances, so
fail_messagesdoesn't change for them.Tests: a batch with a successful record, a failing record, a record that doesn't match the model in the same group, and a successful record in another group, parametrized over
skip_group_on_error. Both cases raisedValidationErrorbefore the change and pass after it.tests/functional/batchpasses on Linux (Python 3.12), along with ruff, mypy, ty, bandit and xenon.User experience
Before: a malformed record after a failure fails the whole invocation, so every record is retried, including already processed ones (and, with
skip_group_on_error=True, the successful records of other message groups).After: the malformed record is reported in
batchItemFailuresalong with the other short-circuited records.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.