Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,10 @@ def _update_record(self, data_record: DataRecord) -> None:
self.expiry_attr: data_record.expiry_timestamp,
},
}

if self.payload_validation_enabled:
item["mapping"][self.validation_key_attr] = data_record.payload_hash

logger.debug(f"Updating record for idempotency key: {data_record.idempotency_key}")
encoded_item = self._json_serializer(item["mapping"])
ttl = self._get_expiry_second(data_record.expiry_timestamp)
Expand Down
33 changes: 33 additions & 0 deletions tests/functional/idempotency/_redis/test_redis_layer.py
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,39 @@ def lambda_handler(event, context):
lambda_handler(mock_event, lambda_context)


def test_idempotent_function_and_lambda_handler_redis_validation_same_payload(
persistence_store_standalone_redis: RedisCachePersistenceLayer,
lambda_context,
):
mock_event = {"user_id": "xyz", "time": "1234"}
persistence_layer = persistence_store_standalone_redis
expected_result = {"message": "Foo"}
config = IdempotencyConfig(event_key_jmespath="user_id", payload_validation_jmespath="time")
calls = 0

@idempotent(persistence_store=persistence_layer, config=config)
def lambda_handler(event, context):
nonlocal calls
calls += 1
return expected_result

# WHEN calling the handler with payload validation enabled
first_result = lambda_handler(mock_event, lambda_context)

# THEN the completed record keeps the payload hash
stored_record = json.loads(next(iter(persistence_layer.client.cache.values())))
assert stored_record["status"] == "COMPLETED"
assert stored_record[persistence_layer.validation_key_attr]

# WHEN calling the handler again with the same payload
second_result = lambda_handler(mock_event, lambda_context)

# THEN the stored response is returned without running the handler again
assert first_result == expected_result
assert second_result == expected_result
assert calls == 1


def test_idempotent_function_and_lambda_handler_redis_basic_no_decode(
persistence_store_standalone_redis_no_decode: RedisCachePersistenceLayer,
lambda_context,
Expand Down