Skip to content

refactor: run metadata queries through craqle - #485

Closed
St4NNi wants to merge 11 commits into
feat/craqle-irokle-updatefrom
refactor/craqle-query-engine
Closed

St4NNi wants to merge 11 commits into
feat/craqle-irokle-updatefrom
refactor/craqle-query-engine

Conversation

@St4NNi

@St4NNi St4NNi commented Sep 24, 2026

Copy link
Copy Markdown
Member

Description

Runs Aruna's local SPARQL queries through Craqle's own query engine instead of copying every visible graph into an in-memory dataset and evaluating it with spareval inside Aruna. Craqle 0.3 now offers bounded, cancellable, authorized queries over an explicit graph list or the caller's visible graphs, with the same union default graph and orphan filtering Aruna implemented itself.

This PR is stacked on the Craqle 0.3 and Irokle 0.3 integration branch.

Changes

  • Evaluate document-scoped queries with CraqleNode::query_in_graphs_with_options and realm-wide queries with CraqleNode::query_with_options, reusing Aruna's graph authorizers.
  • Pass Aruna's row and result byte limits and its cancellation token to Craqle; keep the SELECT/ASK and no-SERVICE validation, the missing-graph check and the final result size check.
  • Map Craqle query limits, cancellation and invalid queries to invalid input, everything else to a backend error.
  • Remove the snapshot copy, the spareval evaluation and result collection code, and the direct spareval dependency.
  • Advance the workspace to 3.0.0-alpha.95.

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.74576% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/craqle-irokle-update@33bb7b6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
operations/src/metadata/handle/query.rs 82.60% 8 Missing ⚠️
operations/src/git/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##             feat/craqle-irokle-update     #485   +/-   ##
============================================================
  Coverage                             ?   87.97%           
============================================================
  Files                                ?      883           
  Lines                                ?   379939           
  Branches                             ?        0           
============================================================
  Hits                                 ?   334248           
  Misses                               ?    45691           
  Partials                             ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@St4NNi

St4NNi commented Sep 24, 2026

Copy link
Copy Markdown
Member Author

Superseded by #486

@St4NNi St4NNi closed this Sep 24, 2026
@St4NNi
St4NNi deleted the refactor/craqle-query-engine branch September 24, 2026 17:51

This branch was successfully deployed

1 active deployment
coverage — c3466e97 Deployed Sep 24, 2026 by St4NNi via Generate Coverage Report #730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant