Repository navigation
Conversation
779590a to
0d92548
Compare
|
agent: [P2, const convention] Mark unchanged bindings const At reviewed head This expresses the read-only intent required by the repository's const guidance. The priority follows our const convention; this is not a demonstrated runtime defect or performance claim. Keep iterators that advance and values that need mutation or ownership transfer mutable where necessary. |
|
agent: [P3, nitpick] Use explicit blocks for new control flow Please add braces to the conditional at PropertyManager.cpp:288–290 and the other new unbraced conditional and loop bodies in the manager and writer changes, following the repository agent guidance. This is a readability and maintenance nitpick; no control-flow failure is demonstrated here. |
d750fd0 to
3df2a64
Compare
nyari-kovacs-arm
left a comment
There was a problem hiding this comment.
Generally, I think this is really high-quality PR, with great clarifying refactors, a clean implementation of the implemented features.
My only concern which I also raised online which I would not say is a blocker for the PR, is that:
- The PropertyManager is a really complex machinery, that also implements features that are not necessarily in line with GStreamer interface design.
- For example deferred changes of properties after state changes. (GStreamer leaves this knowledge for the application to handle from the set metadata for properties)
I would slim down the PropertyManager only to the point that reduces boilerplate for handling the parameter changes from GStreamer mechanisms and nothing more.
8f43999 to
4149b33
Compare
f1afb81 to
5af435d
Compare
5af435d to
7ec5472
Compare
7ec5472 to
fc5ca97
Compare
|
Since the comments of @nyari-kovacs-arm only the bugfixes and nitpick changes remained to stay aligned with the GStreamer parameter handling way. |
Task: EXPKITS-1508 Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
Task: EXPKITS-1508 Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
Task: EXPKITS-1508 Large accepted trace durations can produce point counts outside the int range. Keep the limit in double to avoid undefined float-to-int conversion and incorrect history trimming. Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
Task: EXPKITS-1508 Keep the existing PropertyGuard contract: warn with the required state, leave rejected values unchanged, and require the caller to transition and retry. Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
Task: EXPKITS-1508 Allow property callbacks to stop the pipeline without joining their own WebSocket thread. Serialize toggles to preserve read-modify-write updates. Without this commit: 1. The WebSocket thread calls g_object_set(..., "active", ...). 2. GObject emits notify::active synchronously. 3. An application’s notification handler calls pipeline.set_state(NULL). 4. Shutdown tries to join that same WebSocket thread, causing an exception. Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
Task: EXPKITS-1508 Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
fc5ca97 to
8dc248d
Compare
Goal
Keep OPK property configuration aligned with the standard GStreamer state workflow.
Change
Clean up element code and property IDs, fix tracker trace-retention overflow, and verify rejected writes leave values unchanged. Process browser model toggles in arrival order off the control thread so property callbacks can stop the pipeline. Rename the inference policy to
auto-activate-model-dependencies.Testing
Linux x86_64: nine affected suites pass, including cross-model command ordering, dependency activation and callback-triggered shutdown. Formatting and targeted clang-tidy pass. Requires GLib 2.70 or newer. Native macOS/Windows and Raspberry Pi were not tested.