Skip to content

fix: EXPKITS-1508 order browser model toggles and clean up element properties - #274

Open
msandor93 wants to merge 6 commits into
mainfrom
feature/EXPKITS-1508-runtime-properties
Open

msandor93 wants to merge 6 commits into
mainfrom
feature/EXPKITS-1508-runtime-properties

Conversation

@msandor93

@msandor93 msandor93 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Goal

Keep OPK property configuration aligned with the standard GStreamer state workflow.

Change

Clean up element code and property IDs, fix tracker trace-retention overflow, and verify rejected writes leave values unchanged. Process browser model toggles in arrival order off the control thread so property callbacks can stop the pipeline. Rename the inference policy to auto-activate-model-dependencies.

Testing

Linux x86_64: nine affected suites pass, including cross-model command ordering, dependency activation and callback-triggered shutdown. Formatting and targeted clang-tidy pass. Requires GLib 2.70 or newer. Native macOS/Windows and Raspberry Pi were not tested.

@msandor93
msandor93 requested review from a team as code owners November 12, 2026 07:15
@msandor93
msandor93 force-pushed the feature/EXPKITS-1508-runtime-properties branch 2 times, most recently from 779590a to 0d92548 Compare November 12, 2026 09:05

Copy link
Copy Markdown
Contributor

agent: [P2, const convention] Mark unchanged bindings const

At reviewed head 0d9254878f1fd857ebae72d7e2116f4bfa701d7e, bytesSent in tcp_writer.cpp:48 is never reassigned. Please declare it const ssize_t and apply the same convention to the unchanged flags and accepted_fd bindings in that file and registeredType in opkcomm.cpp.

This expresses the read-only intent required by the repository's const guidance. The priority follows our const convention; this is not a demonstrated runtime defect or performance claim. Keep iterators that advance and values that need mutation or ownership transfer mutable where necessary.

Copy link
Copy Markdown
Contributor

agent: [P3, nitpick] Use explicit blocks for new control flow

Please add braces to the conditional at PropertyManager.cpp:288–290 and the other new unbraced conditional and loop bodies in the manager and writer changes, following the repository agent guidance.

This is a readability and maintenance nitpick; no control-flow failure is demonstrated here.

@msandor93
msandor93 force-pushed the feature/EXPKITS-1508-runtime-properties branch 2 times, most recently from d750fd0 to 3df2a64 Compare November 12, 2026 11:15

@nyari-kovacs-arm nyari-kovacs-arm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I think this is really high-quality PR, with great clarifying refactors, a clean implementation of the implemented features.

My only concern which I also raised online which I would not say is a blocker for the PR, is that:

  • The PropertyManager is a really complex machinery, that also implements features that are not necessarily in line with GStreamer interface design.
    • For example deferred changes of properties after state changes. (GStreamer leaves this knowledge for the application to handle from the set metadata for properties)

I would slim down the PropertyManager only to the point that reduces boilerplate for handling the parameter changes from GStreamer mechanisms and nothing more.

@msandor93
msandor93 force-pushed the feature/EXPKITS-1508-runtime-properties branch 3 times, most recently from 8f43999 to 4149b33 Compare November 12, 2026 13:27
@msandor93
msandor93 marked this pull request as draft November 13, 2026 06:07
@msandor93
msandor93 force-pushed the feature/EXPKITS-1508-runtime-properties branch 6 times, most recently from f1afb81 to 5af435d Compare November 13, 2026 12:07
@msandor93
msandor93 marked this pull request as ready for review November 13, 2026 12:23
@msandor93 msandor93 changed the title feat: EXPKITS-1508 configure OPK properties during operation fix: EXPKITS-1508 order browser model toggles and clean up element properties Nov 13, 2026
@msandor93
msandor93 force-pushed the feature/EXPKITS-1508-runtime-properties branch from 5af435d to 7ec5472 Compare November 13, 2026 13:09
@msandor93
msandor93 enabled auto-merge (squash) November 16, 2026 03:01
@msandor93
msandor93 force-pushed the feature/EXPKITS-1508-runtime-properties branch from 7ec5472 to fc5ca97 Compare November 16, 2026 08:58
@msandor93

msandor93 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor Author

Since the comments of @nyari-kovacs-arm only the bugfixes and nitpick changes remained to stay aligned with the GStreamer parameter handling way.

Task: EXPKITS-1508
Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
Task: EXPKITS-1508
Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
Task: EXPKITS-1508

Large accepted trace durations can produce point counts outside the int range.
Keep the limit in double to avoid undefined float-to-int conversion and
incorrect history trimming.

Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
Task: EXPKITS-1508

Keep the existing PropertyGuard contract: warn with the required state, leave
rejected values unchanged, and require the caller to transition and retry.

Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
Task: EXPKITS-1508

Allow property callbacks to stop the pipeline without joining their own
WebSocket thread. Serialize toggles to preserve read-modify-write updates.

Without this commit:

1. The WebSocket thread calls g_object_set(..., "active", ...).
2. GObject emits notify::active synchronously.
3. An application’s notification handler calls pipeline.set_state(NULL).
4. Shutdown tries to join that same WebSocket thread, causing an exception.

Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
Task: EXPKITS-1508

Signed-off-by: Megyeri Sandor <Sandor.Megyeri@arm.com>
@msandor93
msandor93 force-pushed the feature/EXPKITS-1508-runtime-properties branch from fc5ca97 to 8dc248d Compare November 16, 2026 10:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants