[gregberge]

Description

Fixes ARG-514. argosScreenshot and argosAriaSnapshot now work on a window launched with Playwright's _electron.launch(). Before this change they threw Snapshots can't be taken without a viewport., and then Can't take screenshots without a browser.

• Viewport. When page.viewportSize() is null, the SDK reads window.innerWidth/innerHeight from the page. This also makes viewport: null contexts work in regular browsers.
• Browser. When context().browser() is null (Playwright's types say that only happens for Electron and Android), the SDK reads Electron/<version> from the user agent and records { name: "electron", version }. The Argos app already has an Electron label and icon. If the app replaced its user agent, the SDK records no browser instead of guessing: the API requires a version string, the UI renders it as v{version}, and an Android context would otherwise be labeled Electron.
• viewports option. It now throws on pages without a viewport. Calling setViewportSize on an Electron window can't be undone, and Playwright has no public API to clear it. On Electron 38.8.6, a 2× window stayed at 1× afterwards and ignored a later window resize.
• Where the viewports checks run. Both checks (iframe and no viewport) now run with the other argument checks, before the capture index, prepare and beforeAll. A rejected call no longer leaves the page stabilized or uses up a capture index. This also changes the existing iframe error, which previously fired after those steps.

Type of changes

enhancement

Checklist

• I have read the CONTRIBUTING doc (the repo has none)
• The commits message follows the Conventional Commits' policy
• Lint and unit tests pass locally
• I have added tests if needed

Optional checks:

• My changes requires a change to the documentation
• I have updated the documentation accordingly: docs(playwright): document taking screenshots of Electron apps docs#265

Further comments

• Tests. Unit tests cover the browser detection. Two e2e tests run Chromium with viewport: null: one checks the metadata viewport, the other checks the viewports error. CI doesn't run Electron itself, since that would need Electron and xvfb on Linux.
• Manual check. I ran it against a real Electron 38.8.6 app, from a plain script and through the Playwright test runner with the Argos reporter. Metadata: viewport 900×618, browser electron / 38.8.6. With a custom user agent there's no browser field. Full-page captures and ARIA snapshots work.
• Docs. docs(playwright): document taking screenshots of Electron apps docs#265 replaces the argos upload workaround in the Playwright FAQ. It should merge after this ships.
• Not covered here. @argos-ci/puppeteer has the same failure with defaultViewport: null, which is a separate change. The reporter's warning about missing launchOptions args also shows for Electron projects, where those options don't apply.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
argos-js-sdk-reference	Ready	Preview	Oct 21, 2026 12:31pm UTC

[linear-code]

ARG-514