Repository navigation
fix(generate-release-summary): accept bracket classes in the tag glob - #15
Merged
Merged
Conversation
release-start and release-pr-refresh pass '<prefix>[0-9]*'; the ref check only neutralised '*', so every tag glob they build was refused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`release-start` and `release-pr-refresh` pass `[0-9]` as the tag glob, but the ref check in `generateReleaseSummary.js` only neutralised `` before validating, so every glob the workflows build was refused ("Refusing unsafe tag glob"). The selftest only exercises the default `v*`; app-backend is the first consumer to run `release-start` and hit it.
`isSafeTagGlob` now replaces every glob token (`*`, `?`, `[...]`) with a ref character before the check. Unit test covers the accepted shapes and still refuses shell metacharacters.
🤖 Generated with Claude Code