feat!: vendor the selenium-support page factory and wait engine - #2459
Merged
Merged
Conversation
Phase 3 of removing the Selenium dependency footprint. FluentWait, Wait, Sleeper, @FindBy/@FindBys/@FindAll/@CacheLookup, PageFactory and the field decorator/locator classes now live in io.appium.java_client.support, a self-contained package tree (selenium-api, jspecify and JDK only, enforced by a checkstyle import-control rule) so it can be extracted later. Selenium's own @FindBy-family annotations are still honored when selenium-support is on the classpath. BREAKING CHANGE: selenium-support is no longer a dependency of the library. Page objects should import FindBy, FindBys, FindAll, CacheLookup and PageFactory from io.appium.java_client.support. AppiumFluentWait now extends the vendored FluentWait, the deprecated functions.ExpectedCondition is removed, and PageFactory.initElements(driver, ...) is no longer provided. Users of WebDriverWait, ExpectedConditions or EventFiringDecorator must declare selenium-support themselves. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
mykola-mokhnach
requested review from
SrinivasanTarget,
saikrishna321 and
valfirst
as code owners
October 1, 2026 17:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 of removing the Selenium dependency footprint. FluentWait, Wait, Sleeper, @FindBy/@FindBys/@FindAll/@CacheLookup, PageFactory and the field decorator/locator classes now live in io.appium.java_client.support, a self-contained package tree (selenium-api, jspecify and JDK only, enforced by a checkstyle import-control rule) so it can be extracted later. Selenium's own @FindBy-family annotations are still honored when selenium-support is on the classpath.
BREAKING CHANGE: selenium-support is no longer a dependency of the library. Page objects should import FindBy, FindBys, FindAll, CacheLookup and PageFactory from io.appium.java_client.support. AppiumFluentWait now extends the vendored FluentWait, the deprecated functions.ExpectedCondition is removed, and PageFactory.initElements(driver, ...) is no longer provided. Users of WebDriverWait, ExpectedConditions or EventFiringDecorator must declare selenium-support themselves.