Skip to content

Add apdex_score metric and update filter docs - #101

Merged
itssimon merged 1 commit into
mainfrom
update-metrics-and-filter-docs
Nov 4, 2026
Merged

itssimon merged 1 commit into
mainfrom
update-metrics-and-filter-docs

Conversation

@itssimon

@itssimon itssimon commented Nov 4, 2026

Copy link
Copy Markdown
Member
  • Adds the apdex_score metric: listed in --metrics help and the skill, and stored in a new apdex_score column in the DuckDB metrics table (added to existing databases with ALTER TABLE).
  • Documents --interval as ISO 8601 durations (PT1M to P1M, including PT5M, PT15M and P1W).
  • Rewrites the --filters help for metrics, request-logs and traces as operators by field type:
    • is_null and is_not_null are listed only for nullable fields.
    • event_name is removed; event filters use key.
    • Metrics string fields list ilike and not_ilike, and consumer_id no longer lists range operators the API rejects.
    • Sets verbatim_doc_comment on metrics and request-logs, whose filter help was rendered as run-on paragraphs.
  • Replaces the three per-command operator lists in references/commands.md with one shared Filters section, and marks nullable fields in the request logs and traces field tables.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.01%. Comparing base (1c9f20a) to head (afb0b2a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   91.99%   92.01%   +0.01%     
==========================================
  Files          13       13              
  Lines        2487     2491       +4     
==========================================
+ Hits         2288     2292       +4     
  Misses        199      199              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itssimon
itssimon force-pushed the update-metrics-and-filter-docs branch from a108181 to afb0b2a Compare November 4, 2026 23:29
@itssimon
itssimon merged commit 8566368 into main Nov 4, 2026
7 checks passed
@itssimon
itssimon deleted the update-metrics-and-filter-docs branch November 4, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant