Skip to content

Refactor Jakarta EE integration tests with Graphene page objects - #2944

Merged
lprimak merged 3 commits into
apache:mainfrom
lprimak:simplify-jakarta-tests
Nov 7, 2026
Merged

lprimak merged 3 commits into
apache:mainfrom
lprimak:simplify-jakarta-tests

Conversation

@lprimak

@lprimak lprimak commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Refactor Jakarta EE browser tests to use reusable Graphene page objects and a shared session-controls fragment, keeping assertions in the tests while centralizing locators, navigation, and guarded interactions. Inject deployment URLs directly into the page objects.

Preserve the existing test scenarios, deployment factories, Ajax/HTTP guards, and session/cookie handling. Also update flowlogix-jee to 11.7.6 and use unique deployment archive names.

Arquillian reference

Related upstream bug: arquillian/arquillian-core#934 (fix: arquillian/arquillian-core#935). With multiple deployments, JUnit 5 parameter enrichment loses the selected deployment context and Graphene overwrites its context-root URL with null. These page objects therefore navigate using injected deployment URLs rather than static Graphene.goTo(). This PR does not fix or close the upstream issue.

Once Arquillian is fixed, the code can be further simplified by using Graphene.goTo() instead of manual navigation

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • Committers: Make sure a milestone is set on the PR
  • Committers: Use "Squash and Merge" to combine all commits into one when merging a PR when appropriate.

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@github-actions github-actions Bot added java Pull requests that update Java code tests xml labels Nov 5, 2026
@lprimak lprimak changed the title Simplify jakarta tests Refactor Jakarta EE integration tests with Graphene page objects Nov 5, 2026
@lprimak
lprimak merged commit a2f7ba2 into apache:main Nov 7, 2026
19 checks passed
@lprimak
lprimak deleted the simplify-jakarta-tests branch November 7, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code tests xml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant