Repository navigation
Conversation
…zableReadParallel
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace the fixed 100 ms sleep in
testLinearizableReadParallelwith explicit synchronization using a test state machine.The test waits until the asynchronous write enters
applyTransactionand blocks it before updating the counter. It then verifies that the stale read returns1, initiates a linearizable read, releases the write, and verifies that the linearizable read returns2.This removes the timing assumption that could cause the linearizable read to return
1when the asynchronous write was delayed.This fixes an intermittent failure observed in
https://github.com/apache/ratis/actions/runs/38951714056/job/117144457810#step:11:1420
What is the link to the Apache JIRA
JIRA: RATIS-2760. Fix flaky ReadOnlyRequestWithLongTimeoutTests.testLinearizableReadParallel
How was this patch tested?
unit tests