Repository navigation
RATIS-2743. Move read request handling from RaftServerImpl to a new ReadRequestHandler - #1638
Merged
Merged
Conversation
amaliujia
force-pushed
the
split-read-request-handler
branch
from
October 14, 2026 04:44
5061262 to
916a833
Compare
amaliujia
force-pushed
the
split-read-request-handler
branch
from
October 14, 2026 04:53
cc5f462 to
923b9ed
Compare
szetszwo
reviewed
Oct 14, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
@amaliujia , the change looks good.
Let's also remove the checkstyle suppression
+++ b/dev-support/checkstyle.xml
@@ -60,10 +60,6 @@
</module>
<module name="SuppressWarningsFilter"/>
- <module name="SuppressionSingleFilter">
- <property name="checks" value="FileLength"/>
- <property name="files" value="[/\\]ratis-server[/\\]src[/\\]main[/\\]java[/\\]org[/\\]apache[/\\]ratis[/\\]server[/\\]impl[/\\]RaftServerImpl\.java"/>
- </module>
Contributor
Author
Yes, it is the time now. Done. |
szetszwo
approved these changes
Oct 15, 2026
szetszwo
left a comment
szetszwo
left a comment
Contributor
There was a problem hiding this comment.
+1 the change looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move read request handling from RaftServerImpl to a new ReadRequestHandler
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2743
How was this patch tested?
Existing tests