Repository navigation
[Python] Keep REST commits with callbacks on the native path - #10509
Merged
JingsongLi merged 2 commits intoOct 12, 2026
Merged
Conversation
Contributor
|
LGTM from the code review. The native callback bridge preserves the existing Python context, callback ordering/shared context, late registration, recovery, error propagation, and close/GC lifecycle. The Python Native CI failures are expected until dependency PR apache/paimon-rust#1108 is merged: that job currently builds Rust main, so |
JingsongLi
marked this pull request as ready for review
October 12, 2026 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PyPaimon supports commit callbacks, but registering a callback forces REST commits to use the Python implementation even when Native commit is enabled.
Changes
add_commit_callbackinterface and keep eligible REST commits on the Native publication path.CommitCallbackContextto the existing PythonCommitCallbackContext, including PythonSnapshot,ManifestEntry,GenericRow, canonical file paths and assigned row-tracking metadata.Publication and recovery notification belong to Rust core; Python adapts the existing API. The public Python callback API is unchanged.
Verification
Dependency
Requires apache/paimon-rust#1108. This PR is draft until the Rust change merges; Native CI continues building upstream Rust
main.