Repository navigation
Conversation
Add a partition predicate to the core drop builder and parse structured partition specifications in the SQL procedure. Reject invalid parameters before deletion and preserve dry-run and snapshot-guarded commits. Reuse Java-compatible FLOAT formatting and compare floating partition keys with signed-zero and NaN semantics. Cover partition selection, unchanged index definitions, invalid inputs, and non-committing previews. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
JingsongLi
left a comment
There was a problem hiding this comment.
Requirement fit: SUPPORTED. Implementation: FINDINGS at 47b42b4. Partition-scoped index maintenance has end-to-end value, but the new SQL parser can drop a different LTZ partition's index from the one requested.
Validated against the integration merge with main ae858ea: all 49 original SQL procedure tests, 17 core drop tests, 39 partition-format tests, and the stale-snapshot commit guard pass. An independent actual SQL write/build/select/selective-drop probe also preserves query results. A second actual SQL probe under TZ=Asia/Shanghai, with nonlegacy LTZ partitions, reproduces the wrong-partition deletion described inline. Please cover this supported timezone/partition-format combination before production use.
Parse non-legacy LTZ partition values in the system-local timezone while preserving UTC semantics for legacy names and explicit timezone offsets. Accept legacy names with omitted zero seconds and reject ambiguous or nonexistent local times before deletion. Cover SQL deletion in isolated timezones, timestamp precision, retained index definitions, invalid parameters, and non-committing dry runs. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Purpose
drop_global_indexdeclaredpartitionsbut rejected it, while the core builder could only drop matching indexes across all partitions.Brief change log
Tests
80 focused tests passed, covering partition selection, retained index definitions, invalid parameters, floating-point regressions, dry-run, and stale snapshots. CI-pinned formatting, strict Clippy, dependency and license checks passed.
API and Format
Adds
GlobalIndexDropBuilder::with_partition_filter. No storage format changes.Documentation
Document structured
partitionssyntax in the procedure module.