Skip to content

fix long and slow commands - #30

Merged
xiaoxiang781216 merged 2 commits into
apache:mainfrom
raiden00pl:flood-detection
Oct 12, 2026
Merged

xiaoxiang781216 merged 2 commits into
apache:mainfrom
raiden00pl:flood-detection

Conversation

@raiden00pl

Copy link
Copy Markdown
Member
  • device: report a slow command as TIMEOUT, not flood

  • command_builder: anchor the match_all lookahead pattern

found in open vela CI: https://github.com/zhn-test/public-actions/actions/runs/37871891459/job/113633498233

Only mark the device as flooding when its output never stops after
the command timeout. Output that still arrives at the timeout but
then goes quiet is just a slow command.

Signed-off-by: raiden00pl <raiden00@railab.me>
Unanchored (?=.*X) lookaheads are retried at every buffer position
and each scans to the end, so one search over a 100 KB console dump
took seconds and large outputs such as help timed out.

Signed-off-by: raiden00pl <raiden00@railab.me>
zhangning21 added a commit to zhn-test/public-actions that referenced this pull request Oct 12, 2026
Verification only. Same nuttx/apps/LTP combination as run 37871891459.
@xiaoxiang781216
xiaoxiang781216 merged commit 02c35df into apache:main Oct 12, 2026
6 checks passed
zhangning21 added a commit to zhangning21/public-actions_openvela that referenced this pull request Oct 13, 2026
The rv-virt:citest session excludes a single test case with the
session.json "exclude_test" key added by apache/nuttx-ntfc#31, and its
help/popen cases need the device-flood fix from apache/nuttx-ntfc#30.
Neither is in the ntfc 0.0.3 release on PyPI yet.

Install ntfc from the apache/nuttx-ntfc commit that has both merged,
pinned by full SHA so the CI stays reproducible.  Switch back to a PyPI
release once one containing these changes is published.

Signed-off-by: zhangning21 <zhangning21@xiaomi.com>
xiaoxiang781216 pushed a commit to open-vela/public-actions that referenced this pull request Oct 19, 2026
The rv-virt:citest session excludes a single test case with the
session.json "exclude_test" key added by apache/nuttx-ntfc#31, and its
help/popen cases need the device-flood fix from apache/nuttx-ntfc#30.
Neither is in the ntfc 0.0.3 release on PyPI yet.

Install ntfc from the apache/nuttx-ntfc commit that has both merged,
pinned by full SHA so the CI stays reproducible.  Switch back to a PyPI
release once one containing these changes is published.

Signed-off-by: zhangning21 <zhangning21@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants