Repository navigation
fix long and slow commands - #30
Merged
Merged
Conversation
Only mark the device as flooding when its output never stops after the command timeout. Output that still arrives at the timeout but then goes quiet is just a slow command. Signed-off-by: raiden00pl <raiden00@railab.me>
Unanchored (?=.*X) lookaheads are retried at every buffer position and each scans to the end, so one search over a 100 KB console dump took seconds and large outputs such as help timed out. Signed-off-by: raiden00pl <raiden00@railab.me>
xiaoxiang781216
approved these changes
Oct 10, 2026
zhangning21
added a commit
to zhn-test/public-actions
that referenced
this pull request
Oct 12, 2026
Verification only. Same nuttx/apps/LTP combination as run 37871891459.
cederom
approved these changes
Oct 12, 2026
zhangning21
added a commit
to zhangning21/public-actions_openvela
that referenced
this pull request
Oct 13, 2026
The rv-virt:citest session excludes a single test case with the session.json "exclude_test" key added by apache/nuttx-ntfc#31, and its help/popen cases need the device-flood fix from apache/nuttx-ntfc#30. Neither is in the ntfc 0.0.3 release on PyPI yet. Install ntfc from the apache/nuttx-ntfc commit that has both merged, pinned by full SHA so the CI stays reproducible. Switch back to a PyPI release once one containing these changes is published. Signed-off-by: zhangning21 <zhangning21@xiaomi.com>
xiaoxiang781216
pushed a commit
to open-vela/public-actions
that referenced
this pull request
Oct 19, 2026
The rv-virt:citest session excludes a single test case with the session.json "exclude_test" key added by apache/nuttx-ntfc#31, and its help/popen cases need the device-flood fix from apache/nuttx-ntfc#30. Neither is in the ntfc 0.0.3 release on PyPI yet. Install ntfc from the apache/nuttx-ntfc commit that has both merged, pinned by full SHA so the CI stays reproducible. Switch back to a PyPI release once one containing these changes is published. Signed-off-by: zhangning21 <zhangning21@xiaomi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
device: report a slow command as TIMEOUT, not flood
command_builder: anchor the match_all lookahead pattern
found in open vela CI: https://github.com/zhn-test/public-actions/actions/runs/37871891459/job/113633498233