Repository navigation
graphics/microwindows: update version to suppress warning in mwin/winlib/windlg.c - #3892
Merged
Merged
Conversation
xiaoxiang781216
approved these changes
Oct 20, 2026
michallenc
approved these changes
Oct 20, 2026
cederom
approved these changes
Oct 20, 2026
Microwindows mainline version update to include Gregory Haerr added suppression of the unaligned memory warning in the difficult situation where MS Windows documentation states that the data fields have to be aligned by resource generation tools but implementation should accept unaligned data to support already existing binary applications. As it is not expected to use original binaries in NuttX, the fields and resources should obey alignment but structures intended for construction of the resources have to be defined as packed to allow correct stacking of extended dialog sections. Signed-off-by: Pavel Pisa <ppisa@pikron.com>
ppisa
force-pushed
the
mwin-windlg-warning-suppress
branch
from
October 20, 2026 21:33
73e2a21 to
3515b91
Compare
Contributor
Author
|
I have corrected the commit message length and added description but the build fails on something which I consider totally unrelated to the Microwindows HASH reference change. |
jerpelea
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microwindows mainline version update to include Gregory Haerr added
suppression of the unaligned memory warning in complicated location
where MS Windows documentation states that the data fields have to
be aligned by resource generation tools but implementation should
accept unaligned data to support already existing binary applications.
Impact
Should allow to move forward final pieces integration from [GSoC 2026] Providing X11 Support Using NanoX
The warning is blocking
apache/nuttx#19912
Testing
nanoxterm and nanoxcalc under qemu-intel64.
The change between referenced Microwindows versions is only single
pragma to supress warning so I have not run much more testing for now.