Repository navigation
games/nxdoom: add CMake build support - #3862
Merged
Merged
Conversation
Closes CMake build gap for apps/games/NXDoom identified in issue apache/nuttx#19549: - Adds apps/games/NXDoom/CMakeLists.txt matching Makefile options. - Configures nxdoom application with priority, stacksize, and module options. - Supports core sources, dehacked sources, base sources, and doom sources. - Supports conditional compilation for CONFIG_GAMES_NXDOOM_ENDOOM, CONFIG_GAMES_NXDOOM_NET, CONFIG_GAMES_NXDOOM_SOUND, and CONFIG_GAMES_NXDOOM_RTTTL_MUSIC. - Formatted with cmake-format and verified with checkpatch.sh. Signed-off-by: Swatantra Yadav <maverickswatantra@gmail.com>
xiaoxiang781216
approved these changes
Oct 17, 2026
8 tasks
Contributor
|
Maybe let's wait for #3860 to be merged, and then update this PR so Make and CMake are the same. Otherwise we will have a diversion. |
Contributor
Author
|
Sounds good, @linguini1! I will keep an eye on #3860. As soon as it merges into master, I will rebase and update |
acassis
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the CMake vs. Make build-system gap for
apps/games/NXDoomidentified in issue apache/nuttx#19549 ("[Analysis] CMake vs. Make Build-System Gap Analysis"):Adds
apps/games/NXDoom/CMakeLists.txtproviding CMake build configuration for the NXDoom game port:nxdoomapplication target vianuttx_add_applicationwith configurable priority (CONFIG_GAMES_NXDOOM_PRIORITY) and stack size (CONFIG_GAMES_NXDOOM_STACKSIZE).i_system.c,m_argv.c,m_misc.c,z_native.c), dehacked sources, base sources, and doom core engine sources.Makefile:CONFIG_GAMES_NXDOOM_ENDOOM: includessrc/i_endoom.cand textscreen widgets.CONFIG_GAMES_NXDOOM_NET: includes networking logic and textscreen widgets.CONFIG_GAMES_NXDOOM_SOUND: includes audio, MIDI, and sound effect sources.CONFIG_GAMES_NXDOOM_RTTTL_MUSIC: includes RTTTL music playback support.src,src/doom,textscreen, andpcsound.Addresses apache/nuttx#19549
Together with #3861, this completes 100% CMake build support for all games in
apps/games.Impact
NXDoom.Testing
cmake-formatand verified withcheckpatch.sh.sim:nsh(withCONFIG_GAMES_NXDOOM=y,CONFIG_ALLOW_GPL_COMPONENTS=y,CONFIG_DRIVERS_VIDEO=y,CONFIG_VIDEO_FB=y,CONFIG_CRYPTO=y,CONFIG_LIBC_LOCALE=y).Build Log:
(Note: NXDoom runtime execution requires an external DOOM IWAD game data file (e.g.
doom1.wad) in/data/and an active framebuffer display driver; verified static library compilation and symbol linking).