Repository navigation
Backport MYFACES-4770 to 4.0.x - #1114
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MYFACES-4770
Backport of #1112 to 4.0.x.
Summary
Same change as on
main:ViewScopeCDIMap.put()returns the previous value instead of the internalContextualInstanceInfowrapper.Evidence
ViewScopeCDIMapTest.testPutReturnsPreviousValuefails withexpected: <first> but was: <...ContextualInstanceInfo@...>After: passes;
impl1588 tests, 0 failures, 0 errors (JDK 11, as in the 4.0.x CI)Merge Danger
Door: two-way
Blast Radius: small
Clean cherry-pick. Only callers using the return value of
getViewMap().put(...)with CDI enabled are affected.