Skip to content

BREAKING CHANGE: prepare the basic Java17 env (1/3) #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imbajin merged 26 commits into from
Oct 5, 2026
+3,782 −459
Merged

BREAKING CHANGE: prepare the basic Java17 env (1/3) #3261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
1844d88
refactor(build): establish Java 17 runtime and cluster test foundation
contrueCT Sep 22, 2026
0e216bd
fix(build): keep legacy Gremlin scripts runnable on Java 17
contrueCT Sep 22, 2026
f94a357
chore(deps): refresh the Java 17 compatibility inventory
contrueCT Sep 22, 2026
a923814
fix(ci): align foundation tests and cluster PD configuration
contrueCT Sep 23, 2026
e2cb8ab
fix(store): preserve prior GraphId reservations after repair
contrueCT Sep 25, 2026
85cdb60
fix(dist): declare upgraded Commons dependencies
contrueCT Sep 25, 2026
bdce410
fix(ci): wait for PD readiness
imbajin Oct 2, 2026
1e31f6d
chore(ci): align required checks with Java 17
imbajin Oct 4, 2026
4e11540
docs: clarify test JVM access requirements
imbajin Oct 4, 2026
5607650
fix(store): upgrade Fastjson for the RCE patch
imbajin Oct 4, 2026
7e6da14
fix(test): pin safe Commons Text for cluster tests
imbajin Oct 4, 2026
edd0f9f
fix(store): run GraphId controller tests
imbajin Oct 4, 2026
0e30e3b
fix(store): use Jupiter for controller tests
imbajin Oct 4, 2026
ec4e4d7
chore(build): sync the reviewed runtime baseline
contrueCT Oct 4, 2026
dee9e3b
fix(test): isolate temporary RPC listeners
contrueCT Oct 4, 2026
40c0a39
test(store): synchronize concurrent scan failure setup
contrueCT Oct 4, 2026
6a7318f
chore: merge stable CI runtime from master
imbajin Oct 4, 2026
1d32a04
chore(build): sync latest ASF master
contrueCT Oct 4, 2026
bc0a892
fix(commons): preserve Java 11 library bytecode
imbajin Oct 4, 2026
2168f1e
fix: upgrade Ivy to 2.6.0
imbajin Oct 4, 2026
18790b4
chore(ci): cancel superseded PR runs
imbajin Oct 4, 2026
0b98eb0
chore: merge master into foundation
imbajin Oct 4, 2026
d157b9f
chore: preserve foundation CI updates
imbajin Oct 4, 2026
c5bf9b9
chore(ci): cancel superseded Helm PR runs
imbajin Oct 4, 2026
71ef36d
fix: support spaces in test checkout paths
imbajin Oct 4, 2026
804a0e7
chore: retain remote Helm workflow updates
imbajin Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/.java-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
11
17
5 changes: 5 additions & 0 deletions .github/workflows/check-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ on:
permissions:
contents: read

# Keep the newest PR run; preserve independent push, release and manual runs.
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
dependency-check:
runs-on: ubuntu-latest
Expand Down
28 changes: 26 additions & 2 deletions .github/workflows/cluster-test-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ on:
- '!**/AGENTS.md'
- '!**/CLAUDE.md'

# Keep the newest PR run; preserve independent push, release and manual runs.
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
cluster-test:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -59,8 +64,27 @@ jobs:

- name: Run simple cluster test
run: |
mvn test -pl hugegraph-cluster-test/hugegraph-clustertest-test -am -P simple-cluster-test
timeout 45m mvn test -pl hugegraph-cluster-test/hugegraph-clustertest-test \

@bitflicker64 bitflicker64 Oct 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important: this PR changes the cluster-test lifecycle (AbstractEnv start timeouts, ServerNodeWrapper port readiness, Gremlin port rewriting, pd.peers in the template) and adds EnvUtilTest, GremlinServerConfigTest and AbstractNodeWrapperTest, but none of it ran on this head. gh api repos/apache/hugegraph/actions/workflows reports Cluster Test CI as disabled_manually, and its last run was in October 2025. No other active workflow builds hugegraph-cluster-test with tests. The PR body says CI on this head is the merge gate, so the lane that covers the "cluster test foundation" part of the title is missing from that gate. I ran mvn test -pl hugegraph-cluster-test/hugegraph-clustertest-minicluster locally on JDK 17 and the three new unit tests pass. The simple and multi cluster suites, which depend on the new readiness logic, are still unverified. Please get Cluster Test CI re-enabled and run against this head, or link a passing run of both cluster profiles on this exact SHA, before merge.

@imbajin imbajin Oct 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechecked the upstream workflow state: Cluster Test CI is still disabled_manually. The workflow file has simple/multi cluster commands, but that does not establish that either profile ran on this PR head. Keeping this open for the separate CI work; local compilation/unit tests and package validation are not substitutes for those cluster runs.

-am -P simple-cluster-test

- name: Run multi cluster test
run: |
mvn test -pl hugegraph-cluster-test/hugegraph-clustertest-test -am -P multi-cluster-test
timeout 45m mvn test -pl hugegraph-cluster-test/hugegraph-clustertest-test \
-am -P multi-cluster-test

- name: Show cluster diagnostics on failure
if: failure()
run: |
echo "[ci] java processes:"
ps -ef | grep -E "HugeGraph|hg-|java" | grep -v grep || true
echo "[ci] listening tcp ports:"
(ss -ltnp || netstat -ltnp || true) 2>&1
find hugegraph-cluster-test -path '*/logs/*' -type f | sort | while read -r log; do
echo "--- tail -n 200 $log ---"
tail -n 200 "$log" || true
done
find . -path '*/surefire-reports/*' -type f \
\( -name '*.txt' -o -name '*.xml' \) | sort | while read -r report; do
echo "--- tail -n 120 $report ---"
tail -n 120 "$report" || true
done
5 changes: 5 additions & 0 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ on:
schedule:
- cron: '33 0 * * 5'

# Keep the newest PR run; preserve independent push, release and manual runs.
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
analyze:
env:
Expand Down
11 changes: 9 additions & 2 deletions .github/workflows/commons-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ on:
- 'test-*'
pull_request:

# Keep the newest PR run; preserve independent push, release and manual runs.
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
java-runtime:
uses: ./.github/workflows/java-runtime.yml
Expand Down Expand Up @@ -53,11 +58,13 @@ jobs:

- name: Run common test
run: |
mvn test -pl hugegraph-commons/hugegraph-common -Dtest=UnitTestSuite -DskipCommonsTests=false
mvn test -pl hugegraph-commons/hugegraph-common -Dtest=UnitTestSuite \
-DskipCommonsTests=false -Dsurefire.failIfNoSpecifiedTests=true

- name: Run rpc test
run: |
mvn test -pl hugegraph-commons/hugegraph-rpc -Dtest=UnitTestSuite -DskipCommonsTests=false
mvn test -pl hugegraph-commons/hugegraph-rpc -Dtest=UnitTestSuite \
-DskipCommonsTests=false -Dsurefire.failIfNoSpecifiedTests=true

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v7
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/docker-build-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ on:
- '!**/AGENTS.md'
- '!**/CLAUDE.md'

# Keep the newest PR run; preserve independent push, release and manual runs.
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
docker-bake-check:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -137,6 +142,15 @@ jobs:
echo "Healthcheck: $HC"
[[ "$HC" != "null" ]] || { echo "ERROR: HEALTHCHECK missing in ${{ matrix.dockerfile }}"; exit 1; }

- name: Verify Java 17 runtime in ${{ matrix.dockerfile }}
run: |
JAVA_VERSION=$(docker run --rm --entrypoint java "$IMAGE_ID" -version 2>&1)
echo "$JAVA_VERSION"
grep -Eq 'version "17\.' <<< "$JAVA_VERSION" || {
echo "ERROR: expected a Java 17 runtime in ${{ matrix.dockerfile }}"
exit 1
}

- name: Test server entrypoint property mapping
if: matrix.dockerfile == 'hugegraph-server/Dockerfile'
run: bash hugegraph-server/hugegraph-dist/docker/test/test-docker-entrypoint.sh
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/helm-chart-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ on:
permissions:
contents: read

# Keep the newest PR run; preserve independent push, release and manual runs.
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
lint-and-render:
runs-on: ubuntu-latest
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/licence-checker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ on:
- 'release-*'
pull_request:

# Keep the newest PR run; preserve independent push, release and manual runs.
concurrency:
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
check-license:
runs-on: ubuntu-latest
Expand Down
Loading
Loading