Repository navigation
Conversation
…lures Signed-off-by: Nguyen Quang Minh <135627235+n24q02m@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3259 +/- ##
============================================
+ Coverage 41.40% 41.60% +0.20%
+ Complexity 7337 7315 -22
============================================
Files 802 794 -8
Lines 69792 69135 -657
Branches 9312 9267 -45
============================================
- Hits 28897 28767 -130
+ Misses 37604 37083 -521
+ Partials 3291 3285 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
imbajin
marked this pull request as draft
October 2, 2026 17:37
51 of 96 tasks
This was referenced Oct 4, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
HG-19 follow-up to #3241, within #3242. The proposed top-level
errorsfield makes existing Java clients reject even successful Cypher responses. Move the metadata intostatus.attributes.errorswhile preserving the existing envelope, status and message. Recognize actual translation-1.0.4 parser failures asHugeGraph.Cypher.SyntaxErrorand remove the unavailable parameter-binding hint/code.This branch preserves Nguyen Quang Minh's original commit
ed8344d19ab303a46cb4e9fdb67340815c37e1c4as its parent. Depends on #3241: the PR targets Apachemasterbecause the source PR is in another contributor's fork; until #3241 lands, GitHub includes its original commit in this comparison. The repair-only diff ised8344d19ab303a46cb4e9fdb67340815c37e1c4..HEAD. Please coordinate integration of both PRs; this does not supersede or overwrite the original contribution.Main Changes
requestId,statusandresultat the top level. Put the existing structured error list in the client-compatible attributes map on failure.docs/cypher-api.md.Verifying these changes
mvn clean compile -Dmaven.javadoc.skip=truepasses;mvn editorconfig:formatandgit diff --checkpass.mvn test -pl hugegraph-server/hugegraph-test -am -P unit-test -Dtest=CypherErrorTest -Dsurefire.failIfNoSpecifiedTests=false: 8 tests, 0 failures/errors/skips. Original head: 6 of the 8 regression tests fail.CypherClientCompatibilityTestusing realRestResult.readObject(Response.class): 4/4 pass with each locally available Client 1.7.0 and development 1.8.0 jar. Original head fails both current-success and current-failure deserialization for each jar; legacy fixtures and the top-level-errors negative control pass. Commands are in the API doc.date(), and undefined variables. Unbound$namestill translates to Cypher null.Limitations: live
CypherApiTestand Hubble UI were not run; Hubble'sQueryService.executeCypher-> ClientCypherManager->CypherAPI->RestResultpath was traced at Toolchain3b385c3d2f1c04f7fa4b4534b4b1ec220627bfb5. No cluster, live-data or matching-RC acceptance was performed. Independent repair verification remains with the originating reviewer through HG-17.Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO: repository documentation is complete; paired website alignment remains with its author before coordinated publication.Doc - DoneDoc - No NeedRepository:
docs/cypher-api.md. Paired website: apache/hugegraph-doc#499 at6f52040de2b7613690fb6cc50aafd6aa7af031a2, left untouched. The optional bound-query fork hugegraph#238 and TinkerPop migration are outside this repair.