Repository navigation
fix: retain licenses in source archives - #364
Merged
Merged
Conversation
- retain existing release docs in native Git archives - check source archive legal files in the license job - trigger Computer CI when archive rules change
- keep the license assertion within the code line limit - preserve the same native archive checks - retain explicit bash failure propagation
MrJs133
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native source archives excluded
computer-dist/release-docs, so rebuilding the distribution produced binary tarballs withoutLICENSE,NOTICEorlicenses/. Include the existing release docs ingit archiveso the packaging process can bundle them.Check archived legal files in the existing license job, and trigger the existing Computer CI when
.gitattributeschanges.Validation: the native archive check fails before the fix and passes after it. Source RAT and the native Maven build pass; the rebuilt binary includes every bundled legal file unchanged. Workflow lint and independent review pass. The Server 1.7.0/latest integration and unit matrix, Java/Go CodeQL and both license checks pass.