Repository navigation
feat(computer): prepare 1.8.0 for Java 17 - #363
Merged
Merged
Conversation
- align Commons, Client and Loader with the shared revision - preserve offline file loading and legacy edge schemas - align Java, Hadoop, jetcd, gRPC and Netty compatibility - fix generated builders and shaded POM metadata and streamline CI
imbajin
marked this pull request as ready for review
October 10, 2026 04:02
Manage Protobuf 3.22.3 consistently across modules. Prevent Loader HBase dependencies selecting Protobuf 2.5. Match the runtime used by the staged Server SDK.
Exclude the unused Loader Flink CDC connector. Regenerate the dependency inventory from native Maven output. Align bundled licenses and notices with runtime dependencies. Preserve unchanged license text and include shaded notices.
Open java.lang for the existing SOFA Javassist proxy path. Test Server 1.7.0 and latest with bounded CI test steps. Set code width to 120 and Markdown width to 160. Update agent guidance and wrap changed source files.
Quote Maven settings and dependency script paths. Copy shared Maven settings without removing the source file. Pass complete workflow and shell lint checks.
Record the running Server image identity without environment data. Validate the actual core version returned by the Server API. Check the released baseline and record the latest image version.
Upgrade gRPC for compatibility with the managed Netty version. Align Protobuf with the gRPC generated-code runtime contract. Refresh the actual dependency inventory and bundled notices.
- use gRPC 1.76 without metadata-based buffer selection - align Protobuf with the gRPC generated-code runtime - refresh native dependency and bundled license reports - retain the current Netty and jetcd versions
- retain fail-fast connection behavior after jetcd upgrade - assert the gRPC unavailable status independently of message text - capture Surefire threads when integration tests stall
- retain offline primary-key vertex IDs and properties - resume queued data sends after batched acknowledgements - finish cancelled Kubernetes jobs deleted before initialization - verify Recycler reuse and capacity through public behavior
- configure the handler before opening the connection - prevent asynchronous callbacks from consuming stubbing - preserve the existing data uniformity assertions
- resolve Central before Apache staging from the POM - remove stage profiles and CI settings switches - replace Markdown lint settings with EditorConfig - condense agent guidance and restore optional Markdown wrapping
- restore the original client builder chain alignment - keep the edge schema lookup on one line - change whitespace only without adding formatting rules
MrJs133
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computer moves from Java 11 and Commons/Toolchain 1.3.0 to Java 17 and 1.8.0, sharing one revision for Commons, Client and Loader. Maven resolves Central first and falls back to Apache staging automatically, removing CI repository switches.
The official offline Loader factory preserves schemas, primary-key vertex IDs, properties and edge endpoints. Updated runtime dependencies and JVM options support Java 17. Etcd keeps fail-fast connections, batched ACKs resume queued sends, and deleting an unfinished Kubernetes job completes its cancellation. Tests use public Recycler behavior and finish Mockito stubbing before asynchronous callbacks.
CI covers Server 1.7.0 and latest Docker images, records their actual versions, and starts HDFS with the Java 17-compatible Hadoop 3.5 image. Bundled licenses match the resolved dependencies; the unused Loader Flink CDC connector is excluded. EditorConfig keeps code at 120 characters and leaves Markdown wrapping optional. AGENTS.md retains concise project-specific guidance.
Validation: both Server matrix jobs pass integration and unit tests; Java/Go CodeQL and both license checks pass. Targeted regressions, changed-source Checkstyle, workflow/shell checks and independent review also pass.