Repository navigation
SSE: report socket timeouts through onFailure and reconnect - #926
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
…f closing silently SocketTimeoutException extends InterruptedIOException and was classified as a benign cancellation by DefaultEventSource#isBenignCancel. A read timeout closed the stream with onClosed(), without onFailure() and without a reconnect.
Member
|
CC @shinseongsu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SocketTimeoutException extends InterruptedIOException and DefaultEventSource#isBenignCancel classified it as a benign cancellation. A read timeout closed the stream with onClosed(), without onFailure() and without a reconnect.
With a client configured with a socket timeout, a server that sends one event and goes silent leaves the application with no failure callback and no further connection attempts. A socket timeout is a network failure, so it now reaches onFailure(ex, willReconnect) and follows the backoff policy. A plain InterruptedIOException is still treated as benign.
Reproduced against a local server that sends one event and stays silent, client with a 5 second soTimeout: before, onClosed at 5.0s, no onFailure, 1 connection; after, onFailure(SocketTimeoutException, willReconnect=true) every ~5s and a new connection each time (4 in 20s).
Tests: new DefaultEventSourceIntegrationTest cases fail on master and pass with the change; httpclient5-sse verify with checkstyle, 53 tests, 0 failures.