Repository navigation
Conversation
SystemDefaultCredentialsProvider asked java.net.Authenticator for RequestorType.PROXY credentials whenever no SERVER credentials were found, whatever host issued the challenge. With an Authenticator that answers proxy requests, as is common for corporate proxies, any origin server replying 401 Basic was sent the proxy credentials. Skip the PROXY lookup when the auth scope is the target of the request being executed; 407 challenges from the proxy resolve as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SystemDefaultCredentialsProvider, the default credentials provider of every client builder, falls back to asking java.net.Authenticator for RequestorType.PROXY credentials for whatever host issued the challenge, so with the common
getRequestorType() == PROXYauthenticator any origin server that answers 401 Basic is sent the JVM's proxy credentials (reproduced with HttpClients.createDefault() and HttpAsyncClients.createDefault(), direct and behind a proxy); skip the PROXY lookup when the auth scope is the host:port of the request being executed, which leaves 407 handling for forwarded and CONNECT requests unchanged.