Repository navigation
Conversation
ok2c
reviewed
Nov 4, 2026
| // against the origin of another request | ||
| clientContext.setCookieSpec(null); | ||
| clientContext.setCookieOrigin(null); | ||
|
|
Member
There was a problem hiding this comment.
@Hsnmohd Very good catch.
However, I would rather keep the cookie spec and cookie origin null in case the Cookie header has manually added and not generated by RequestAddCookies, and let ResponseProcessCookies take no action. Would you agree to that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store the cookie spec and origin before RequestAddCookies short-circuits on a caller-set Cookie header, otherwise ResponseProcessCookies validates the response's Set-Cookie against the origin left in the context by the previous exchange and a cookie set by one host is stored and replayed under another host's domain.