Repository navigation
Do not put the query string of a request into observation names and tags - #920
Open
arturobernalg wants to merge 5 commits into
Open
arturobernalg wants to merge 5 commits into
arturobernalg wants to merge 5 commits into
Conversation
…be executed manually during release preparation due to those tests failing intermittently in CI
Since the default verifier fallback was removed, CLIENT or BOTH policy with a null HostnameVerifier performed no hostname verification at all. ConscryptClientTlsStrategy and the deprecated DefaultClientTlsStrategy constructor now select the BUILTIN policy when no verifier is given, and AbstractClientTlsStrategy rejects CLIENT or BOTH without a verifier.
Once the CONNECT tunnel is established a 407 comes from the origin. It was evaluated against the proxy auth exchange, which failed with a NullPointerException or IllegalStateException. The response is now returned to the caller as is.
The target name was passed as the endpoint name when connecting to the first hop, so the proxy certificate was verified against, and the SNI set to, the target virtual host instead of the proxy. The target name is now used only when upgrading to TLS for the target.
The span name and the per-URI I/O tag carried the query string, which may hold tokens and makes the tag cardinality unbounded. They now contain the scheme, host and path only.
arturobernalg
force-pushed
the
observation-uri-redaction
branch
from
November 2, 2026 19:00
dab5dde to
c942e46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The span name and the per-URI I/O tag carried the query string, which may hold tokens and makes the tag cardinality unbounded. Observed with a request to
/path?token=SECRET: the classic span name wasGET http://127.0.0.1:PORT/path?token=SECRET, the async oneGET /path?token=SECRET, and theuritag/path?token=SECRET.The name and the tag now carry the scheme, host and path only. Userinfo and fragment did not reach them in the observed cases and are stripped defensively. Metric names and tag keys are unchanged.
Tests added, classic and async.