Repository navigation
Verify the TLS endpoint of an HTTPS proxy against the proxy host - #918
Merged
arturobernalg merged 1 commit intoNov 1, 2026
Merged
Conversation
The target name was passed as the endpoint name when connecting to the first hop, so the proxy certificate was verified against, and the SNI set to, the target virtual host instead of the proxy. The target name is now used only when upgrading to TLS for the target.
Member
|
@arturobernalg HttpClient does not really support |
ok2c
approved these changes
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an HTTPS proxy the target name was passed as the endpoint name when connecting to the first hop, so the proxy certificate was verified against, and the SNI was set to, the target virtual host instead of the proxy. The target name is now used only when upgrading to TLS for the target.
Test added.