Repository navigation
Do not skip hostname verification when the CLIENT policy has no verifier - #916
Merged
Merged
Conversation
ok2c
approved these changes
Nov 1, 2026
Since the default verifier fallback was removed, CLIENT or BOTH policy with a null HostnameVerifier performed no hostname verification at all. ConscryptClientTlsStrategy and the deprecated DefaultClientTlsStrategy constructor now select the BUILTIN policy when no verifier is given, and AbstractClientTlsStrategy rejects CLIENT or BOTH without a verifier.
arturobernalg
force-pushed
the
client-policy-verifier
branch
from
November 1, 2026 10:00
1b90f73 to
2a60d23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the default verifier fallback was removed (#649),
HostnameVerificationPolicy.CLIENTorBOTHwith a nullHostnameVerifierperforms no hostname verification.ConscryptClientTlsStrategy(ctx)and the deprecatedDefaultClientTlsStrategyconstructor end up in that state.This keeps the separation between verification policy and verifier configuration:
ConscryptClientTlsStrategyand the deprecatedDefaultClientTlsStrategyconstructor selectBUILTINwhen no verifier is givenAbstractClientTlsStrategyrejectsCLIENT/BOTHwithout a verifierAlternative to #914. Tests added.