Fix non-interactive template uploads - #228
Open
dheeraj12347 wants to merge 1 commit into
Open
dheeraj12347 wants to merge 1 commit into
dheeraj12347 wants to merge 1 commit into
Conversation
Contributor
Author
|
Hi @jl0815, @DaanHoogland I’ve opened PR #228 for #227. I traced the non-interactive template upload crash to UploadFiles() dereferencing a nil spinner when HasShell=false. The fix makes spinner handling optional while preserving interactive progress behavior, and I added a regression test that performs an actual multipart upload in non-interactive mode. go test ./..., go vet ./..., and git diff --check all pass. Would appreciate your review when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #227.
Template uploads using
filepath=failed in non-interactive mode becauseUploadFiles()unconditionally used the CLI spinner.StartSpinner()returns nil when CloudMonkey is running without a shell,which caused a nil pointer dereference when the spinner was accessed.
This change:
HasShell=falseValidation
go test ./...✅go vet ./...✅git diff --check✅Fixes #227