Repository navigation
Conversation
When one element is included through several junctions, the pipeline has several instances of it with the same strong cache key. With multiple builders they are built or pulled in parallel and write the same artifact concurrently, which can fail the build. Build and pull queues now process one instance per cache key at a time. Other instances wait, then link the cached artifact under their own name, or take over if the first job failed.
ownik
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow,
gtristan and
juergbi
as code owners
October 23, 2026 12:16
Contributor
|
Thanks, this should help with #2120. I'll try to review it soon. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the same element is included through several junctions, its instances share a strong cache key and with multiple builders get built or pulled in parallel, writing the same artifact concurrently. This change makes the build and pull queues process one instance per cache key at a time. The others wait and then reuse the cached artifact, or take over if the first job failed.
Added tests in tests/scheduler/deduplication.py. I ran the full test suite and checked that everything passes.
Please review.