Skip to content

ARTEMIS-6285 Use JDK version of ConcurrentHashSet - #6743

Merged
jbertram merged 1 commit into
apache:mainfrom
amarkevich:newKeySet
Oct 6, 2026
Merged

jbertram merged 1 commit into
apache:mainfrom
amarkevich:newKeySet

Conversation

@amarkevich

Copy link
Copy Markdown
Contributor

ConcurrentHashMap.newKeySet()

@amarkevich amarkevich changed the title replace custom ConcurrentHashSet with JDK's replace custom ConcurrentHashSet with JDK's ConcurrentHashMap.newKeySet() Sep 25, 2026
@tabish121

Copy link
Copy Markdown
Contributor

While swapping to use the now inbuilt Set type from ConcurrentHaspMap is a good change vs a custom rolled variant, it is probably a bit hasty to just delete the class from the commons library given it is publicly accessible and could be used by folks in custom broker plugins or the like. It would probably make sense to deprecate those classes and remove them in a major version.

@jbertram

jbertram commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

I opened ARTEMIS-6285 for this. You should reference it in your commit message (along with the shorter description).

@amarkevich amarkevich changed the title replace custom ConcurrentHashSet with JDK's ConcurrentHashMap.newKeySet() ARTEMIS-6285 Use JDK version of ConcurrentHashSet Oct 6, 2026
@jbertram
jbertram merged commit d0c2b17 into apache:main Oct 6, 2026
6 checks passed
@amarkevich
amarkevich deleted the newKeySet branch October 6, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants