Conversation
The Dev PR workflow runs on pull_request_target, where github.ref is the base branch rather than the PR ref. All PRs therefore shared a single concurrency group, and with cancel-in-progress any new run cancelled the run in progress on another PR, leaving a cancelled "Ensure PR format" check behind. Key the group on the PR number instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
The
Dev PRworkflow runs onpull_request_target, wheregithub.refis the base branch (refs/heads/main), not the PR ref. Its concurrency group therefore resolved toapache/arrow-java-refs/heads/main-Dev PRfor every PR, and withcancel-in-progress: truea new run on one PR cancelled the run in progress on another.This leaves a cancelled "Ensure PR format" check on the losing PR, which shows up as a failure. For example on #1295 the job was cancelled with:
This change keys the concurrency group on the PR number, so runs are only cancelled by newer runs of the same PR.
Note that
pull_request_targetuses the workflow from the base branch, so this only takes effect once merged.