GH-1261: Reject out-of-range dictionary indices - #1309
Open
efegokdemir wants to merge 2 commits into
Open
efegokdemir wants to merge 2 commits into
efegokdemir wants to merge 2 commits into
Conversation
efegokdemir
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
September 23, 2026 18:03
This comment has been minimized.
This comment has been minimized.
lidavidm
approved these changes
Sep 24, 2026
jbonofre
reviewed
Oct 3, 2026
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
jbonofre
force-pushed
the
codex/issue-1261-dictionary-index-bounds
branch
from
October 3, 2026 12:07
5697fdd to
99077aa
Compare
Signed-off-by: Efe Gökdemir <gokdemirefe1903@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Reject negative and dictionaryCount indices before copying dictionary values.
Add regression coverage for both invalid bounds and allocator cleanup, and keep the existing struct decode regression focused on the later invalid field.
Closes #1261.
AI assistance was used during development; the complete diff and test results were reviewed by the author.