Repository navigation
Takes the geo-ip-service address from the Consul env template and removes the address file - #11
Merged
Merged
Conversation
…template like its other dependencies
…lient so the address is always a plain URL
jim-toth
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api-service takes the
geo-ip-serviceaddress from the Consul env template, the same way it takes every other dependency, and a change of that address restarts it. The address file and everything built for it are removed:GEO_IP_SERVICE_URLis a plain required URL, and the geo-ip-clientbaseUrlis a string.Changes
operations/api-service-stage.hcl,operations/api-service-live.hcl:GEO_IP_SERVICE_URLrendered fromgeo-ip-service-<env>|anyin theconfig.envtemplate; thelocal/geo-ip-service-urltemplate andGEO_IP_SERVICE_URL_FILEremoved.apps/api-service:GEO_IP_SERVICE_URLis required;GEO_IP_SERVICE_URL_FILEand the exactly-one check are removed.packages/geo-ip-client:baseUrlis a string only;urlFromFileand the function form ofbaseUrlare removed.Verified
bun run typecheckandbun testpass under Bun 1.4.3.nomad job validatepasses for both job definitions.