Repository navigation
Accept node-set suffixes in ends-with - #175
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ends-with("Everyday Italian", //book[1]/title)compiles but panics during evaluation because only the first argument accepts a node-set. The equivalent call withstring(//book[1]/title)works. This prevents XML/HTML queries from comparing a string against a suffix stored in another node.Apply the same existing string/node-set conversion to both arguments. A selected node contributes its string value and an empty node-set contributes the empty string. Numeric and boolean arguments retain their existing rejection behavior.
Validation on upstream base
6a83bdc6e20f75669fea1f29402e1f2ea8676111:go test ./...andgo test -race ./...pass after the fix with Go 1.26.4 on macOS arm64, including the existing tests that reject numeric arguments.git diff --checkpasses.The expected suffix results follow the ends-with rules and the package's existing first-argument node-set conversion. This does not add collations or general XPath 2.0 support.
AI assistance: implementation and regression tests prepared with Codex.