Repository navigation
Format numbers in text the way encoding/json does - #29
Merged
Merged
Conversation
InnerText, OutputXML and the Data of text nodes formatted numbers with %v, so 1000000 became 1e+06 and 123456789 became 1.23456789e+08. Format them the way encoding/json does instead, which matches the string value the XPath navigator already returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text nodes format JSON numbers with
%v, which switches to exponent notation for many ordinary values (encoding/json only does that below 1e-6 or from 1e21 up):NodeNavigator.Value()already formats numbers withjson.Marshal, so XPath sees1000000whileInnerText(),OutputXML()andNode.Datashow1e+06.This adds a small
formatValuehelper that formatsfloat64values withjson.Marshaland leaves everything else as%v. It is used for text nodeData,InnerTextandOutputXML, so all three now match what XPath sees. Strings and booleans are unchanged.Testing:
TestLargeNumberTextchecksInnerText()for four numbers and checksOutputXML(). On master, three of theInnerText()checks and theOutputXML()check fail. With the change,go test .andgo vet .pass. I only ran them on Go 1.25.