Repository navigation
Reject HTTP error responses in LoadURL - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
LoadURL now returns an error for final HTTP responses outside 200 to 299. A 404 response with valid JSON currently returns a document and no error. Successful responses and redirects keep their existing parsing behavior. Response bodies are closed on every return.
The tests cover successful statuses, redirects, JSON error bodies and body closure. The original implementation fails 14 new subtests.
The native
go test . -v -covercommand passes on Go 1.23.4 and 1.24.0.go test -race ./... -count=1,go build ./...andgo vet ./...pass.