feat: [Remote rendering 3.5b] client uses server owned variables - #153
Draft
LKasianAnsys wants to merge 6 commits into
Draft
LKasianAnsys wants to merge 6 commits into
LKasianAnsys wants to merge 6 commits into
Conversation
LKasianAnsys
force-pushed
the
feat/3.5a-move-variable-ownership-to-server
branch
from
October 2, 2026 17:22
a6e2619 to
328ccf1
Compare
LKasianAnsys
force-pushed
the
feat/3.5b-client-uses-server-owned-variables
branch
from
October 2, 2026 17:30
c04cb7f to
77400e7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Addresses #23
Status: WIP
Copilot summary
This pull request refactors how variable metadata and range information are managed and delivered between the server and client in the Visor application. The changes move ownership of variable records from the client to the server, ensuring that variable state is always sourced from server deliveries rather than being reconstructed or duplicated on the client. The update also simplifies the flow for updating and applying variable ranges, and introduces new utility methods for UI components to refresh their state based on the latest variable records.
Key changes include:
Variable Record Ownership & Delivery
VisorFrontend.tsx,VisorVariableManager.tsx) [1] [2]VisorVariableManagerto provide methods for setting delivered variable records (setRecords) and projecting them as needed, replacing the previous approach of aggregating from local data arrays. (VisorVariableManager.tsx)Variable Range Application & Synchronization
sendVariableRangeAsyncand updatedsetVariableRangeAsyncinVisorFrontendto report range changes to the server and apply them locally, with error handling for failed sends. (VisorFrontend.tsx) [1] [2]VisorFrontend.tsx,VisorSceneGraph.tsx) [1] [2]UI Synchronization Enhancements
refreshSelectionAsyncmethod to thePanel_TopRight_Utilclass, allowing UI panels to refresh their selection and displayed ranges after variable records are updated. (Panel_TopRight_Util.tsx,Panel_TopRight.tsx) [1] [2] [3]VisorFrontend.tsx)Testing and Internal API Adjustments
VisorSceneGraphPartTriggers.test.tsx,VisorSceneGraph.tsx) [1] [2] [3]Type and Documentation Updates
defaultRange. (VisorVariableManager.tsx) [1] [2]These changes collectively improve consistency, reduce duplication, and make the client more robust to server-driven updates of variable state.