refactor(@angular/build): consolidate library asset collection and watch check - #34230
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…tch check Remove `checkAssetChanges` and reuse the assets collected by `collectAssetsToEmit` in watch mode so asset matching only runs once per watch iteration.
alan-agius4
changed the title
83cf2bf to
5f90459
Compare
|
/gemini review |
alan-agius4
added
action: review
There was a problem hiding this comment.
Code Review
This pull request refactors the asset collection and change detection logic in the Angular library builder. It replaces the checkAssetChanges utility with a more direct approach that collects assets to emit (collectAssetsToEmit) during the watch loop, passing them directly to the build action. This eliminates redundant asset matching and simplifies the watch loop logic. Additionally, the responsibility of adding asset paths to the watched files set is moved from the asset collection utility to the build action. There are no review comments, and I have no feedback to provide.
alan-agius4
added
action: merge
|
This PR was merged into the repository. The changes were merged into the following branches:
|
2 participants
Remove
checkAssetChangesand reuse the assets collected bycollectAssetsToEmitin watch mode so asset matching only runs once per watch iteration.