Skip to content

fix: read response for all requests so that subsequent calls aren't stuck in Request-sent state #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkwok-atg wants to merge 1 commit into from
Closed

fix: read response for all requests so that subsequent calls aren't stuck in Request-sent state #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/amplitude_experiment/remote/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,12 @@ def __do_fetch(self, user, fetch_options: FetchOptions = None):
response = conn.request('POST', '/sdk/v2/vardata?v=0', body, headers)
elapsed = '%.3f' % ((time.time() - start) * 1000)
self.logger.debug(f"[Experiment] Fetch complete in {elapsed} ms")
# always read so the keep-alive connection is reusable
response_as_bytes = response.read()
if response.status != 200:
raise FetchException(response.status,
f"Fetch error response: status={response.status} {response.reason}")
json_response = json.loads(response.read().decode("utf8"))
json_response = json.loads(response_as_bytes.decode("utf8"))
variants = evaluation_variants_json_to_variants(json_response)
self.logger.debug(f"[Experiment] Fetched variants: {json.dumps(variants, default=str)}")
return variants
Expand Down